-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go IDONTWANT #553
Open
ppopth
wants to merge
9
commits into
libp2p:master
Choose a base branch
from
ppopth:idonthave
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Go IDONTWANT #553
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
3b4d97b
Replace sending channel with the smart rpcQueue
ppopth 773c26f
Implement UrgentPush in the smart rpcQueue
ppopth 1f36b9d
Add IDONTWANT to rpc.proto and trace.proto
ppopth 3e3d6d7
Send IDONTWANT right before validation step
ppopth dfd81e8
Add urgent flag to SendRPC in trace.proto
ppopth 055ffa0
Test GossipSub IDONWANT sending
ppopth 6b24d35
Send IDONWANT only for large messages
ppopth ec6ded9
Revert "Add urgent flag to SendRPC in trace.proto"
ppopth 63f5ca7
Handle IDONTWANT control messages
ppopth File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to log the error (at very low priority) if it is not a closed indicator.