Skip to content
This repository has been archived by the owner on Aug 19, 2022. It is now read-only.

when passed an event bus, automatically clean up disconnected peers #184

Merged
merged 1 commit into from
Dec 2, 2021
Merged

when passed an event bus, automatically clean up disconnected peers #184

merged 1 commit into from
Dec 2, 2021

Conversation

marten-seemann
Copy link
Contributor

@marten-seemann marten-seemann commented Dec 2, 2021 •
edited

Fixes #93. Closes #180.

vyzo
vyzo approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, have we resolved the import mess?

@marten-seemann
Copy link
Contributor Author

Yes, by having a PeerstoreC option in go-libp2p (instead of Peerstore). Then we can pass in the event.Bus.

Base automatically changed from remove-peer to master December 2, 2021 08:06
@marten-seemann marten-seemann merged commit 49c99d9 into master Dec 2, 2021
@marten-seemann marten-seemann deleted the pstore-cleanup branch December 2, 2021 08:27
@raulk raulk mentioned this pull request Jan 13, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vyzo vyzo vyzo approved these changes

@Stebalien Stebalien Awaiting requested review from Stebalien

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Forget unnecessary metadata on disconnect
2 participants
@marten-seemann @vyzo