fix: flaky test by skipping connectivity checks #955
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennis-tra
commented
Sep 29, 2023
| RequestConcurrency: 3, // MAGIC | ||
| RequestTimeout: time.Minute, // MAGIC | ||
| DefaultQuorum: 0, // MAGIC | ||
| SkipConnectivityCheck: false, |
There was a problem hiding this comment.
Should this rather be on a RoutingConfig struct?
There was a problem hiding this comment.
Yes.
What about just using the following to make the RoutingConfig usable externally
type RoutingConfig = internal.coord.RoutingConfig
By skipping connectivity checks we reduce the chances of simultaneously opening a stream that will block connection establishment. Context: libp2p/go-libp2p#2589
dennis-tra
force-pushed
the
v2-flaky-TestQuorumReachedPrematurely
branch
from
559a162
to
042bba3
Compare
|
Maybe a better solution for your test is to allow a Coordinator to be created with a NoopRoutingBehaviour. The behaviours are intended to be modular and replaceable but we haven't exposed a convenient way of doing that. |
|
As per #954 this needs to be applied to zikade |
|
Closing as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By skipping connectivity checks we reduce the chances of simultaneously opening a stream that will block connection establishment.
Context: libp2p/go-libp2p#2589