Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fullrt dht bug fixes #719

Merged
merged 6 commits into from May 27, 2021
Merged

fullrt dht bug fixes #719

merged 6 commits into from May 27, 2021

Commits on May 27, 2021

  1. fullrt: only log percentage completion of bulk sends if there are at … 

    …least 100 messages to send
    @aschmahmann
    aschmahmann committed May 27, 2021
    Copy the full SHA
    8cce656 View commit details
    Browse the repository at this point in the history

  2. fullrt: abort bulk sending earlier if the context is cancelled

    @aschmahmann
    aschmahmann committed May 27, 2021
    Copy the full SHA
    c522396 View commit details
    Browse the repository at this point in the history

  3. fullrt: fix dividing up bulk sending of keys into groups

    @aschmahmann
    aschmahmann committed May 27, 2021
    Copy the full SHA
    eaca669 View commit details
    Browse the repository at this point in the history

  4. fullrt: comment to explain why bulk sending splits into groups

    @aschmahmann
    aschmahmann committed May 27, 2021
    Copy the full SHA
    0da8065 View commit details
    Browse the repository at this point in the history

  5. fullrt: execOnMany abort early if executing on no peers

    @aschmahmann
    aschmahmann committed May 27, 2021
    Copy the full SHA
    5eb9aaa View commit details
    Browse the repository at this point in the history

  6. Cleanup execOnMany and allow it to be used in both sloppy and non-slo… 

    …ppy mode

The execOnMany function was able to exit prematurely, leaving its child goroutines running.  These would write to a channel that closed after execOnMany returned in findProvidersAsyncRoutine. The function is now able to run both in a sloppy mode where it allows goroutines to be cleaned up after the function has completed as well a safer non-sloppy mode where goroutines will complete before the function returns. The sloppy mode is used for DHT "get" operations like FindProviders and SearchValues whereas the non-sloppy mode is used for "put" operations like PutValue and Provide (along with their bulk operation equivalents).

This fixes ipfs/kubo#8146
    @gammazero @aschmahmann
    gammazero authored and aschmahmann committed May 27, 2021
    Copy the full SHA
    daab800 View commit details
    Browse the repository at this point in the history