Fix race condition in execOnMany #717
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The execOnMany function was exiting prematurely due to an error, leaving its child goroutines running. These would write to a channel that closed after execOnMany returned in findProvidersAsyncRoutine, Fixed counting error so that goroutines all finish before execOnMany exits. This fixes ipfs/kubo#8146
aschmahmann
reviewed
May 20, 2021
Merged
aschmahmann
reviewed
May 26, 2021
| case <-waitSuccessCh: | ||
| if numSuccess >= numSuccessfulToWaitFor { | ||
| if !t.Stop() { | ||
| <-t.C |
There was a problem hiding this comment.
this will block the first time it's called because the timer is already stopped which means t.Stop() is false, and we've already emptied out the channel.
Doing it this way we need some boolean to check for the first time we've reset the timer. This follows roughly the same pattern as the pause detection timer in this function https://github.com/ipfs/go-ipfs-provider/blob/d391dae4a595473f6797eb5d5b803a529a7bbdbc/batched/system.go#L130
There was a problem hiding this comment.
nm, looks like we're discussing this in #719
|
This will be handled in #719 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
execOnManyfunction was exiting prematurely due to an error, leaving its child goroutines running. These would write to a channel that closed afterexecOnManyreturned infindProvidersAsyncRoutine. Fixed counting error so that goroutines all finish beforeexecOnManyexits.This fixes ipfs/kubo#8146