Change MaxRecordAge from const to var #409
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is to make MaxRecordAge configurable from outside the package so users can set a custom record expiration in their projects.
|
@vyzo's right that we "pretty much do this everywhere". But we really shouldn't use this for anything but debugging. Would adding a functional option work? (opts/options.go) |
|
Yeah I can make the change. Will try to do it this weekend. @aarshkshah1992 if you feel like you can more quickly add it to your PR, let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to make MaxRecordAge configurable from outside the package so
users can set a custom record expiration in their projects.
closes #408