This repository has been archived by the owner on Sep 6, 2022. It is now read-only.
remove the DialTimeout #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The timeout should be a configuration option for the swarm, not a global variable.
|
|
vyzo
reviewed
Dec 19, 2021
Nope. TCP uses an option: https://github.com/libp2p/go-tcp-transport/blob/1c17791c35777091afcb56a0707503bf82532a62/tcp.go#L98-L103 |
|
Confirmed by building go-ipfs using this PR and libp2p/go-libp2p-swarm#302. |
vyzo
reviewed
Dec 19, 2021
Stebalien
approved these changes
Dec 19, 2021
vyzo
approved these changes
Dec 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timeout should be a configuration option for the swarm, not a global variable.
Related change in the swarm: libp2p/go-libp2p-swarm#302.
We should probably do the same for the
AcceptTimeout.