Disovered Addresses Event #171
Conversation
|
|
||
| // EvtDiscoveredAddresses should be emitted when a new dialable address is discovered by a system. | ||
| // This dialable address would then be verified by a system such as AutoNAT. | ||
| type EvtDiscoveredAddresses struct { |
There was a problem hiding this comment.
can we have each event provide a single discovered address?
anyone watching for new addresses will already be wanting to aggregate since addresses may arrive at the same time (e.g. startup) form multiple sources. We can probably reduce the second aggregation here for simplicity
There was a problem hiding this comment.
@willscott But imagine a scenario wherein the "default route" changes and we want to send the new interface addresses. Are you saying we'd send two events here for each new interface address ?
There was a problem hiding this comment.
I would prefer getting two events, since the default route changing also likely will occur at the same time as different externally discovered and different netroute events.
|
@aarshkshah1992 : what are the next steps for this? I'm converting to draft for now. |
For libp2p/go-libp2p#1012.
AutoNAT PR at libp2p/go-libp2p-autonat#98.
As discussed with @Stebalien , sub-systems that discover new dialable addresses will emit this event which will then be consumed by AutoNAT to determine if they are reachable.