Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/_blog: Add rust-libpp2p in 2022 post #26

Merged
merged 17 commits into from Jan 12, 2023

Conversation

mxinden
Copy link
Member

@mxinden mxinden commented Dec 30, 2022

End of the year blog post on rust-libp2p, recapping on the many things in 2022. Also useful reflection exercise for the team.

src/_blog/rust-libp2p-2022.md Outdated Show resolved Hide resolved
@mxinden mxinden marked this pull request as ready for review January 3, 2023 08:32
@mxinden
Copy link
Member Author

mxinden commented Jan 4, 2023

@p-shahi could you give this post a review?

Steve mentioned that you were working on a general libp2p-in-2022 post. Sorry that I missed that. Any suggestions on how to proceed? I am fine with two separate posts.

@mxinden
Copy link
Member Author

mxinden commented Jan 4, 2023

Tried the one-line-per-sentence markdown formatting here to ease reviews and git diffs. Unfortunately this is not properly rendered by our blog, i.e. the blog interprets a single \n as a newline within a paragraph.

Will keep it as is for now. Will reformat before we merge.

(//CC @thomaseizinger for the idea in general and //CC @elenaf9 given that this is exactly the behavior you predicted in our 1on1.)

@marten-seemann
Copy link
Contributor

marten-seemann commented Jan 4, 2023

Does it make sense to have a separate rust-libp2p post here? This would kind of demand a “go-libp2p in 2022” post to be written up as well, and I’m not sure that would be a good use of our time. My preference would be to have a single “libp2p in 2022” post that covers all implementations.

Going forward, I think we’ll be better served by writing blog posts about single topics / features, shortly after we ship those, instead of long summary articles.

@mxinden
Copy link
Member Author

mxinden commented Jan 4, 2023

Does it make sense to have a separate rust-libp2p post here? This would kind of demand a “go-libp2p in 2022” post to be written up as well, and I’m not sure that would be a good use of our time.

I don't think this is an all (js, go, rust, nim, ...) or nothing.

My preference would be to have a single “libp2p in 2022” post that covers all implementations.

Not opposed to a general libp2p post. In case someone volunteers to write such post, I am happy to integrate this one into the general one.

Going forward, I think we’ll be better served by writing blog posts about single topics / features, shortly after we ship those, instead of long summary articles.

My mindset thus far was: As long as the signal-to-noise ratio (/quality) is high, the more blog posts, i.e. the more we share about our work, the better.

@p-shahi
Copy link
Member

p-shahi commented Jan 4, 2023

Steve mentioned that you were working on a general libp2p-in-2022 post. Sorry that I missed that. Any suggestions on how to proceed? I am fine with two separate posts.

Yes I'm working on that.
I think it's fine to have two separate posts as this article is more detailed and I was presenting highlights

Going forward, I think we’ll be better served by writing blog posts about single topics / features, shortly after we ship those, instead of long summary articles.

My mindset thus far was: As long as the signal-to-noise ratio (/quality) is high, the more blog posts, i.e. the more we share about our work, the better.

These posts are retrospectives of what happened in the last year and so I think they're equally valuable as standalone posts for shipped features

Copy link
Member

@p-shahi p-shahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A super quick review! Some suggestions are optional (like the new headers with emojis).
Might be a good idea to have @DannyS03 review this as well 🙏

date: 2022-12-30
permalink: "/2022-12-30-rust-libp2p-in-2022"
translationKey: ''
header_image:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/_blog/rust-libp2p-2022.md Outdated Show resolved Hide resolved
src/_blog/rust-libp2p-2022.md Outdated Show resolved Hide resolved

The rust-libp2p project has made significant strides in 2022, with numerous technical advancements and improvements to the project itself.
Let's take a closer look at some of the technical highlights and on the meta level developments of the project itself.
Note that while I (Max Inden) am writing this blog post, this is the work of many across various organizations.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Note that while I (Max Inden) am writing this blog post, this is the work of many across various organizations.
This is the work of many across various organizations including [Protocol Labs](https://protocol.ai/), [Parity Technologies](https://www.parity.io/), [Sigma Prime](https://sigmaprime.io/), [Iroh](https://iroh.computer/), and [Little Bear Labs](https://littlebearlabs.io/).

Among the three PL steward libp2p projects, I think rust-libp2p is the one that gets most activity/contribution from organizations across the ecosystem. What do you think of highlighting that here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a mention of the organizations and further below is the contributor count. Sounds good?

src/_blog/rust-libp2p-2022.md Show resolved Hide resolved
src/_blog/rust-libp2p-2022.md Show resolved Hide resolved
src/_blog/rust-libp2p-2022.md Outdated Show resolved Hide resolved
src/_blog/rust-libp2p-2022.md Show resolved Hide resolved
src/_blog/rust-libp2p-2022.md Show resolved Hide resolved
src/_blog/rust-libp2p-2022.md Outdated Show resolved Hide resolved
mxinden and others added 5 commits January 5, 2023 15:17
Co-authored-by: Prithvi Shahi <50885601+p-shahi@users.noreply.github.com>
Co-authored-by: Prithvi Shahi <50885601+p-shahi@users.noreply.github.com>
Copy link
Member Author

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate all the help @p-shahi. I addressed all comments.

src/_blog/rust-libp2p-2022.md Outdated Show resolved Hide resolved
src/_blog/rust-libp2p-2022.md Show resolved Hide resolved
Over the year we worked on two new transports, namely [WebRTC](https://github.com/libp2p/rust-libp2p/pull/2622) and [QUIC](https://github.com/libp2p/rust-libp2p/issues/2883), which we both released towards the end of the year as alphas.

WebRTC allows browsers to connect to rust-libp2p based servers without those servers having signed TLS certificates.
QUIC is the better TCP+Noise+Yamux in every dimension, e.g. faster connection establishment, better multiplexing, higher hole punching success rates.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for rephrasing.

Regarding results on Notion, I think we should treat them as preliminary for now and thus not mention them here.

src/_blog/rust-libp2p-2022.md Outdated Show resolved Hide resolved
Copy link
Member

@p-shahi p-shahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!
Two things that occurred to me:

src/_blog/rust-libp2p-2022.md Show resolved Hide resolved
src/_blog/rust-libp2p-2022.md Outdated Show resolved Hide resolved
src/_blog/rust-libp2p-2022.md Outdated Show resolved Hide resolved
Copy link

@elenaf9 elenaf9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice to reflect again on everything the team did in 2022. Thank you for writing this up @mxinden!

src/_blog/rust-libp2p-2022.md Outdated Show resolved Hide resolved
src/_blog/rust-libp2p-2022.md Outdated Show resolved Hide resolved
src/_blog/rust-libp2p-2022.md Outdated Show resolved Hide resolved
src/_blog/rust-libp2p-2022.md Outdated Show resolved Hide resolved
src/_blog/rust-libp2p-2022.md Outdated Show resolved Hide resolved
src/_blog/rust-libp2p-2022.md Outdated Show resolved Hide resolved
src/_blog/rust-libp2p-2022.md Show resolved Hide resolved
src/_blog/rust-libp2p-2022.md Outdated Show resolved Hide resolved
src/_blog/rust-libp2p-2022.md Outdated Show resolved Hide resolved
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome post @mxinden , thanks for writing this up!

It is great to see all these improvements enumerated.

Also feeling a bit proud to have initiated and pushed for a few things that ended up being mentioned here ☺️

Something I think we can still improve on is cycle time (and as an effect of that, velocity). Reduced CI times and more automation are helping with that already but things like our crate structure, release process and changelog management are still hurting that. I am looking forward to seeing those improved so we can ship more things :)

@thomaseizinger
Copy link
Contributor

Tried the one-line-per-sentence markdown formatting here to ease reviews and git diffs. Unfortunately this is not properly rendered by our blog, i.e. the blog interprets a single \n as a newline within a paragraph.

That is a shame. Markdown should not care about single newlines but only start a new paragraph on double newlines ...

@mxinden
Copy link
Member Author

mxinden commented Jan 10, 2023

Thanks everyone for the help here.

@p-shahi this is ready to go live. Do you mind merging whenever you see fit?

@p-shahi
Copy link
Member

p-shahi commented Jan 10, 2023

@mxinden will do, I'm waiting for the blog header from the design team.

Copy link
Contributor

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great recap. Fun to see it laid out in a consolidation place. Thanks for taking this on.

@p-shahi p-shahi merged commit 4b7f7d7 into libp2p:main Jan 12, 2023
@thomaseizinger
Copy link
Contributor

Tried the one-line-per-sentence markdown formatting here to ease reviews and git diffs. Unfortunately this is not properly rendered by our blog, i.e. the blog interprets a single \n as a newline within a paragraph.

Will keep it as is for now. Will reformat before we merge.

(//CC @thomaseizinger for the idea in general and //CC @elenaf9 given that this is exactly the behavior you predicted in our 1on1.)

The source for this behaviour seems to be this configuration option:

md.set({
breaks: true,
})

I submitted a PR to remove this setting: #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants