ci: do not run SSH tests on macOS #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosmn
force-pushed
the
cmn/no-ssh-macos
branch
from
47d87da
to
54933ac
Compare
It looks like the tests don't pass with the current libssh2 on macOS and we don't know what the source is. The library doesn't do these tests so we shouldn't until that is working.
carlosmn
force-pushed
the
cmn/no-ssh-macos
branch
from
54933ac
to
e6e4ba7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library does not run these tests as there seems to be some issues around the current libssh2 and I don't know how to configure macOS CI to use a different version. There is no hope of these tests passing until the library's tests pass.