Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the local ssh for check_connection and stop hiding online skips #889

Merged
merged 2 commits into from Sep 1, 2021
Merged

Use the local ssh for check_connection and stop hiding online skips #889

merged 2 commits into from Sep 1, 2021

Commits on Sep 1, 2021

  1. test: make the check_connection test use the local ssh setup 

    With GitHub shutting down user/pass for Git access, let's take the opportunity
to fix this failing test by using our own local setup instead of having to write
down a password to an account.
    @carlosmn
    carlosmn committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    d3e86f1 View commit details
    Browse the repository at this point in the history

  2. test: don't hide online skipped tests behind definition-time conditio… 

    …nals

Instead do show them as skipped to more accurately represent to the caller that
we have tests which are being skipped.
    @carlosmn
    carlosmn committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    61bb3f5 View commit details
    Browse the repository at this point in the history