Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return GIT_PASSTHROUGH if credentials callback returns nill #626

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Return GIT_PASSTHROUGH if credentials callback returns nill #626

wants to merge 1 commit into from

Conversation

brandonweeks
Copy link

Fixed #625, see libgit2/libgit2#3902 for more information. Since triggering the error condition requires connecting to a repository that requires authentication I wasn't sure what a good way to test this would be.

@carlosmn
Copy link
Member

carlosmn commented Jan 3, 2017

This doesn't look like the correct behaviour in this case. Returning nil from a credentials callback is a bug in that callback and it's completely different from indicating that the callback isn't set, including the error message which would now be misleading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants