Use the local ssh for check_connection and stop hiding online skips
#889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosmn
force-pushed
the
cmn/remote-test-ssh
branch
from
6c91fb3
to
3b099c5
Compare
With GitHub shutting down user/pass for Git access, let's take the opportunity to fix this failing test by using our own local setup instead of having to write down a password to an account.
…nals Instead do show them as skipped to more accurately represent to the caller that we have tests which are being skipped.
carlosmn
force-pushed
the
cmn/remote-test-ssh
branch
from
3b099c5
to
61bb3f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
check_connectiontest is failing as user/pass combinations are no longer allowed. Change it to be use the CI-provided network endpoint which also avoids having to figure out if we can access the Internet.While here, I noticed a lack of
Ss on the output and so I went ahead and changed these definition-time skips to be actual skips so we can see when calling the tests that there are tests which we are skipping, instead of hiding them and pretending that all tests ran fine.