Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config for automatic output device fetching on gwt #7359

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SimonIT
Copy link
Member

@SimonIT SimonIT commented Mar 6, 2024

fixes #7348

Copy link
Contributor

@Frosty-J Frosty-J left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good if it could be changed during the game's runtime (like how the web version of Discord asks for permission when navigating to the "Voice & Video" settings but not the others) but I'm not planning to use this feature so would just like the false default merge. Approved!

Copy link
Member

@crykn crykn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @Frosty-J, but this is good enough for now.

@crykn crykn added this to the 1.12.2 milestone Mar 7, 2024
@Berstanio
Copy link
Contributor

Maybe the limitation for the GWT backend should be mentioned on the interface? That it needs a special property to be set?
Or maybe throwing a exception/printing an error log when doing getAvailableOutputDevices, without the flag set on GWT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GWT requests unnecessary microphone permission
5 participants