Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Pixmap safe to dispose if already disposed #7347

Merged
merged 2 commits into from
May 27, 2024
Merged

Make Pixmap safe to dispose if already disposed #7347

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdee529
Make Pixmap safe to dispose if already disposed
obigu Feb 22, 2024
b0dbd97
Grrr
obigu Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion gdx/src/com/badlogic/gdx/graphics/Pixmap.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ public int getHeight () {

/** Releases all resources associated with this Pixmap. */
public void dispose () {
if (disposed) throw new GdxRuntimeException("Pixmap already disposed!");
if (disposed) Gdx.app.error("Pixmap", "Pixmap already disposed!");
pixmap.dispose();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it safe to run it twice? It calls the next code inside:
private static native void free (long pixmap); /* gdx2d_free((gdx2d_pixmap*)pixmap); */

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made it too fast, fixed!

disposed = true;
}
Expand Down