Do not force-overwrite the LWJGL configuration option GLFW_LIBRARY_NAME #7343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, GLFW_LIBRARY_NAME *always* gets overwritten. That's an issue for people using this property, as there is no way to get around this. The proposal is to only rewrite the configuration if no custom location was used, i.e. the property still has the default value of `null`.
|
I'm not sure why you're using the gdx-lwjgl3-glfw-awt-macos extension if you don't plan on using its GLFW library. But I think we should hold off on the PR anyways, since it becomes obsolete, if we decide to move forward with #7361. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, GLFW_LIBRARY_NAME always gets overwritten. That's an issue for people using this property, as there is no way to get around this. The proposal is to only rewrite the configuration if no custom location was used, i.e. the property still has the default value of
null.