Download NDK versions instead of using shipped ones by the runner

[Berstanio]

Since the NDK version pointed by ANDROID_NDK_HOME can change at any time and newer NDK version discontinue support for older android version, I think it is preferable to pin our NDK version to a specific one.

See #7307 (comment)

I verified that the commands work locally, but I haven't verified them integrated into a GHA.

[Frosty-J]

In this case, we should set ndkVersion "23.2.8568313" so people testing locally get the same results as GitHub Actions. If you wish to use r23 do you no longer stand by #7310 (review) ?

[Berstanio]

In this case, we should set ndkVersion "23.2.8568313" so people testing locally

I don't think this property affects us at all, it shouldn't get picked up by jnigen. The user is responsible on how to set the "NDK_HOME" variable.

do you no longer stand by #7310 (review) ?

I still stand by this review, that android 19 should be reasonable. However, android 16-18 are currently broken in older libGDX versions without a full discussion about it, so I choose to roll it back to this point for the moment. But I have also no real problem with r25.

[obigu]

In this case, we should set ndkVersion "23.2.8568313" so people testing locally

I don't think this property affects us at all, it shouldn't get picked up by jnigen. The user is responsible on how to set the "NDK_HOME" variable.

do you no longer stand by #7310 (review) ?

I still stand by this review, that android 19 should be reasonable. However, android 16-18 are currently broken in older libGDX versions without a full discussion about it, so I choose to roll it back to this point for the moment. But I have also no real problem with r25.

I think it's a good idea to point to a sepecific NDK version to prevent this issue in the future but I'd point to latest one (damage, if any, has already been done). When #7310 is merged (which can be done now) Gdx Setup will be changed immediately to min API 19 fixing the problem for new projects.

[Berstanio]

but I'd point to latest one

The latest one is r26 which discontinues API 19 and 20 though.

[obigu]

but I'd point to latest one

The latest one is r26 which discontinues API 19 and 20 though.

Ok, previous one then :)

[SonicGDX]

I tried doing this on my machine and it said "no properly formatted checksum lines found". But then I realised 53af80a1cce9144025b81c78c8cd556bff42bd0e is the sha1 of the file, not the sha256.

The actual sha256 seems to be 769ee342ea75f80619d985c2da990c48b3d8eaf45f48783a2d48870d04b46108