Add instanced attributes flags to GLSL prefix #7277
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
#define attrib_instancedFlag
for each instanced attribute, mostly to allow declaring an attribute instead of a uniform when the specific attribute is instanced (like I did with u_worlTransform for example).I tested it with this demo that implements instancing
u_worldTransform
: https://github.com/yahel-ck/libgdx_instancing_demoThe demo is using gdx-gltf to render, but it uses the same underlying LibGDX classes.
I tested it on VMs of iOS and Android, and on a physical Android device (Samsung S21).
It wouldn't take much work to implement the demo solely with LibGDX so let me know if you think it's necessary, or if there are any other tests I should make.
Thanks :)