New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Implement launcher zoom callback #7206
base: master
Are you sure you want to change the base?
Conversation
Added launcher zoom callback for live wallpapers introduced in API 30, closes libgdx#7055
This reverts commit a660cb4.
The build check keeps failing without a helpful explanation this time and I think my code and code style is correct... |
You must also adapt the tests to your changes |
Thanks I already looked for Android tests but Android Studio showed me somehow an empty folder, had to go into Project view... Now it should be fine! |
this.zoomConsumed = false; | ||
this.zoom = zoom; | ||
|
||
// can fail if linkedApp == null, so we repeat it in Engine.onResume |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment is either outdated or wrong as this isn't repeated in Engine.onResume?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I indeed forgot some calls of the new method, now it should be all right!
Add missing calls of new notifyZoomChanged method
@SimonIT I think someone with write access has to resolve the remaining conflict in the changelog caused by another listed change for Android. Thanks! |
Added launcher zoom callback for live wallpapers introduced in API 30, closes #7055.
It's basically the same structure as the existing onOffsetsChanged() so I copied the important methods and modified them accordingly. Hope I've done all right!