Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Implement launcher zoom callback #7206

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

patzly
Copy link

@patzly patzly commented Aug 12, 2023

Added launcher zoom callback for live wallpapers introduced in API 30, closes #7055.
It's basically the same structure as the existing onOffsetsChanged() so I copied the important methods and modified them accordingly. Hope I've done all right!

@patzly
Copy link
Author

patzly commented Aug 13, 2023

The build check keeps failing without a helpful explanation this time and I think my code and code style is correct...
Can someone help please? Or is the check maybe not required to succeed when all seems to be correct?

@SimonIT
Copy link
Member

SimonIT commented Aug 13, 2023

2023-08-13T15:58:52.8444540Z   - Gradle detected a problem with the following location: '/home/runner/work/libgdx/libgdx/tests/gdx-tests-android/build/intermediates/packaged_manifests/debug'. Reason: Task ':tests:gdx-tests-android:processDebugResources' uses this output of task ':fetchNatives' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.5.1/userguide/validation_problems.html#implicit_dependency for more details about this problem.
2023-08-13T15:58:53.4431717Z /home/runner/work/libgdx/libgdx/tests/gdx-tests-android/src/com/badlogic/gdx/tests/android/LiveWallpaper.java:41: error: MyLiveWallpaperListener is not abstract and does not override abstract method zoomChange(float) in AndroidWallpaperListener
2023-08-13T15:58:53.4432263Z 

You must also adapt the tests to your changes

@patzly
Copy link
Author

patzly commented Aug 14, 2023

Thanks I already looked for Android tests but Android Studio showed me somehow an empty folder, had to go into Project view... Now it should be fine!

this.zoomConsumed = false;
this.zoom = zoom;

// can fail if linkedApp == null, so we repeat it in Engine.onResume
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is either outdated or wrong as this isn't repeated in Engine.onResume?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I indeed forgot some calls of the new method, now it should be all right!

Add missing calls of new notifyZoomChanged method
@patzly
Copy link
Author

patzly commented Oct 3, 2023

@SimonIT I think someone with write access has to resolve the remaining conflict in the changelog caused by another listed change for Android. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[gdx-backend-android] Implementation of quick settings and app drawer zoom callback missing
3 participants