Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return iOS Insets in logical pixels #6225

Merged
merged 1 commit into from Oct 14, 2020
Merged

Return iOS Insets in logical pixels #6225

merged 1 commit into from Oct 14, 2020

Conversation

obigu
Copy link
Contributor

@obigu obigu commented Oct 14, 2020

Insets API was still returning physical pixels after the changes on #3709. Made the Insets API consistent by returning logical pixels.

MrStahlfelge
MrStahlfelge approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@MrStahlfelge MrStahlfelge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change. I like how clean this now is.

@MrStahlfelge MrStahlfelge merged commit 939088c into libgdx:master Oct 14, 2020
@MrStahlfelge MrStahlfelge added bug graphics Concerning Gdx.graphics ios labels Oct 14, 2020
@obigu obigu deleted the fix-ios-notches branch October 14, 2020 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrStahlfelge MrStahlfelge MrStahlfelge approved these changes

Assignees
No one assigned
Labels
bug graphics Concerning Gdx.graphics ios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@obigu @MrStahlfelge