Set min iOS version to 8.0 #5933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current RoboVM version sets theMinimumOSVersionto 6 if not declared on the app'sInfo.plist. Currently GDX setup doesn't set it so it defaults to 6 which is not supported even by RoboVM itself.Ok, the problem is less important than I originally thought but the PR may still be relevant. Currently RoboVM is not handling properly the
MinimumOSVersion(see MobiVM/robovm#463) which may lead to confusion in terms of what the actual minimum supported iOS version is.MobimVM official minimum supported version is 8. If
MinimumOSVersionis not declared on the app'sInfo.plistit will be set to 8 by default. There's currently a small bug that, in caseMinimumOSVersionis missing, even if it uses iOS 8, it internally adds the key with a value of 6 (instead of 8) to the Info.plist NSBundle, returning the wrong value if reading it programatically.Explicitely setting it in libGDX has the advantage of defining the min iOS version supported by libGDX itself independenlty of MobiVM as well as making it easier to know and change (in most cases users will need to set it to 9 due to being a requirement by many popular 3rd party SDKs).
Also,
armv7has been removed from the list of Required Device Capabilities as All devices that support iOS 8 have it as a capability (see support matrix https://developer.apple.com/support/required-device-capabilities/).