[Scene2d.ui] Adding support for horizontal scrolling (touch pad and touch screen) + fix fractional scroll events #5463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpauty
force-pushed
the
horizontalScrollSupport
branch
from
ce34317
to
40ba812
Compare
jpauty
changed the title
jpauty
force-pushed
the
horizontalScrollSupport
branch
2 times, most recently
from
390ec12
to
d42d679
Compare
Also, adding support for devices which report fractional scrolling amounts. E.g. a mouse with a continuous mouse wheel, or a Mac touch pad. This is currently only supported in lwjgl3. It can probably be added to android and maybe to gwt. InputProcessor scrolled method now receives scroll amount for X and Y. Changed type to float to support devices which report fractional scroll amounts. Updated InputEvent in scene2d accordingly: added scrollAmountX, scrollAmountY attributes and corresponding setters and getters. Input event queue can receive float scrolling values. Since the queue stores the events with integers. Scrolling values are stored in fixed precision format, with 8 bits for the fraction. Updated backends accordingly: lwjgl, lwjgl3, android and gwt.
jpauty
force-pushed
the
horizontalScrollSupport
branch
from
d42d679
to
0119a75
Compare
MrStahlfelge
added
core
|
I like the addition, but the build fails, there are conflicts and there wasn't any other feedbacks by the community. Closing this, feel free to reopen when merged against the latest version. |
|
Hi, I've updated my branch and pushed: https://github.com/jpauty/libgdx/tree/horizontalScrollSupport I cannot reopen this PR. Should I open a new one ? |
|
Yes, please open a new one - I also cannot reopen it for some reason. |
|
Please, see this new PR: #6154 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Since we just start with the new version. I prepared a new PR to fix horizontal scrolling support and fractional scrolling.
Currently horizontal scrolling with a touch pad is not supported. More over, devices which report fractional scrolling values, such as touch pads and mouses with continuous wheels are not supported. The scrolling is super fast, because small scroll increments (0.1) are converted to 1 or -1. See my previous PR for more details.
Cheers,
Julien
Commit message:
Adding support for horizontal scrolling (touch pad and touch screen)
Also, adding support for devices which report fractional scrolling
amounts. E.g. a mouse with a continuous mouse wheel, or a Mac touch
pad. This is currently only supported in lwjgl3. It can probably be
added to android and maybe to gwt.
InputProcessor scrolled method now receives scroll amount for X and
Y. Changed type to float to support devices which report fractional
scroll amounts. Updated InputEvent in scene2d accordingly: added
scrollAmountX, scrollAmountY attributes and corresponding setters and
getters.
Input event queue can receive float scrolling values. Since the queue
stores the events with integers. Scrolling values are stored in fixed
precision format, with 8 bits for the fraction.
Updated backends accordingly: lwjgl, lwjgl3, android and gwt.