Fix Win32 stdcall closure #465
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The stack pointer has been incorrectly restored after a closure call. The issue came up at ruby-ffi: ffi/ffi#649 Patch by Alexander Mitin. Fixes libffi#215
larskanis
added a commit
to larskanis/ffi
that referenced
this pull request
Jan 24, 2019
This temporary switches to a forked libffi, until the fixing PR is merged: libffi/libffi#465 Use the following command to update the submodule: git submodule update --init --remote
larskanis
added a commit
to ffi/ffi
that referenced
this pull request
Feb 18, 2019
This switches to a forked libffi, until the fixing PR is merged: libffi/libffi#465 Use the following command to update the submodule: git submodule update
atgreen
reviewed
Apr 22, 2019
There was a problem hiding this comment.
I believe that this may have been fixed with this commit: e1118af#diff-c4b0832c0aac7d71bfb338c67ef95028
Could you please verify?
|
Stdcall is fixed by a8efc2f , so this PR is obsolete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stack pointer has been incorrectly restored after a closure call.
The issue came up at ruby-ffi: ffi/ffi#649
Patch by Alexander Mitin: #215 (comment)
Fixes #215