Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keepalives support #999

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Keepalives support #999

wants to merge 4 commits into from

Commits on Sep 30, 2020

  1. Add keepalives support

    @marselester
    marselester committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    6ecc178 View commit details
    Browse the repository at this point in the history

  2. Rewrite tests for Go 1.13 compatibility

    @marselester
    marselester committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    d9d4371 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2020

  1. Add OpenConnector to Driver to satisfy DriverContext interface 

    sql.Open will use driver's OpenConnector instead of its
Open method. This will enable TCP keepalive support.

Note, testDriver was added for TestRuntimeParameters since it
expects old fashioned Driver interface (without OpenConnector).
    @marselester
    marselester committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    51502e0 View commit details
    Browse the repository at this point in the history

  2. Update Open func to support keepalive 

    Got rid of OpenConnector for simplicity's sake.

Noticed "pq: current transaction is aborted" in go18_test.go:212,
but it doesn't seem to be related. The same issue popped up in
lib#921.
    @marselester
    marselester committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    5f9a0c9 View commit details
    Browse the repository at this point in the history