Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: reduce allocations in ParseURL #935

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

url: reduce allocations in ParseURL #935

wants to merge 1 commit into from

Commits on Jan 28, 2020

  1. url: reduce allocations in ParseURL 

    If you use e.g. "postgres://" as the connection string, ParseURL will
be called and the result will be computed each time a connection is
established to the database. This can be expensive because a new
strings.Replacer is created each time ParseURL is called. It's also
unnecessary because the output can be computed by the input and for
most processes only a single input will ever exist for the lifetime of
the process.

Reuse the same *Replacer across calls, and also cache the first 100
unique results from ParseURL, to speed up the second and third calls.
    @kevinburke1
    kevinburke1 committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    2f62c43 View commit details
    Browse the repository at this point in the history