Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix server_version parsing #762

Closed
wants to merge 1 commit into from
Closed

Conversation

mkabilov
Copy link

@mkabilov mkabilov commented Jun 13, 2018

Server version string can consist of 2 parts, not always 3

@cheald
Copy link

cheald commented Oct 8, 2018

This has implications for CopyIn usage - when the detected server version is less than 9.0, it falls back to a much slower Sprintf encoding. Merge would be appreciated!

My local startup parses:

server_version
10.5 (Ubuntu 10.5-0ubuntu0.18.04) => input does not match format

So the server version ends up being 0, which then falls back to the slower version.

@Lekensteyn
Copy link

This solves the same issue as #979 but is more complex. I would suggest merging #979 and closing this one. What do you think?

@mkabilov mkabilov closed this Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants