Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove arbitrarly chosen extra_float_digits connection option. #1150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

orian
Copy link

@orian orian commented Jan 11, 2024

No description provided.

@johto
Copy link
Contributor

johto commented Jan 11, 2024

  1. Why do we want to remove this?
  2. Not arbitrarily chosen.

@orian
Copy link
Author

orian commented Feb 13, 2024

It caused me some problems and I would prefer the driver to stick to the database default (or at least document it).

Imho it should be like with default libs, if a user uses simple connector, it should use the default config, but it should also be possible to pass user specific config. I can provide simple proof-of-concept.

I've forked the lib and using my fork to not mess others people assumed behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants