Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky TestConnPrepareContext #1061

Merged
merged 1 commit into from Nov 7, 2021
Merged

Fix flaky TestConnPrepareContext #1061

merged 1 commit into from Nov 7, 2021

Commits on Oct 19, 2021

  1. Fix flaky TestConnPrepareContext 

    TestConnPrepareContext checks it receives an context.DeadlineExceeded. However,
the context isn't necessarily always expired. This causes most of the test runs
to fail for me, only occasionally succeeding. This change ensures the context
used in the test is actually context.DeadlineExceeded. The negative duration
causes the context package to return an already canceled context.
    @mjl-
    mjl- committed Oct 19, 2021
    Copy the full SHA
    2b4fa17 View commit details
    Browse the repository at this point in the history