Skip to content

Commit

Permalink
Add error log for schema admin operation (apache#11427)
Browse files Browse the repository at this point in the history
### Motivation

When I use pulsar-admin schemas to upload schema file with wrong format, I got `HTTP 500 Internal Server Error` from pulsar-admin-tool. 
And I look into broker's log but can not find any related error logs.

### Modifications

export error log when schema admin operation failed.
  • Loading branch information
wangjialing218 committed Jul 23, 2021
1 parent 083bb62 commit 216623d
Showing 1 changed file with 10 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@
import org.apache.pulsar.common.protocol.schema.SchemaVersion;
import org.apache.pulsar.common.schema.LongSchemaVersion;
import org.apache.pulsar.common.schema.SchemaType;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

public class SchemasResourceBase extends AdminResource {

Expand Down Expand Up @@ -123,6 +125,7 @@ public void deleteSchema(boolean authoritative, AsyncResponse response) {
.entity(DeleteSchemaResponse.builder().version(getLongSchemaVersion(version)).build())
.build());
} else {
log.error("[{}] Failed to delete schema for topic {}", clientAppId(), topicName, error);
response.resume(error);
}
return null;
Expand Down Expand Up @@ -162,6 +165,7 @@ public void postSchema(PostSchemaPayload payload, boolean authoritative, AsyncRe
response.resume(Response.status(422, /* Unprocessable Entity */
error.getMessage()).build());
} else {
log.error("[{}] Failed to post schema for topic {}", clientAppId(), topicName, error);
response.resume(Response.serverError().build());
}
return null;
Expand All @@ -173,6 +177,7 @@ public void postSchema(PostSchemaPayload payload, boolean authoritative, AsyncRe
.status(((RestException) error.getCause()).getResponse().getStatus(), error.getMessage())
.build());
} else {
log.error("[{}] Failed to post schema for topic {}", clientAppId(), topicName, error);
response.resume(Response.serverError().build());
}
return null;
Expand Down Expand Up @@ -224,6 +229,7 @@ public void getVersionBySchema(
.thenAccept(version -> response.resume(Response.accepted()
.entity(LongSchemaVersionResponse.builder().version(version).build()).build()))
.exceptionally(error -> {
log.error("[{}] Failed to get version by schema for topic {}", clientAppId(), topicName, error);
response.resume(Response.serverError().build());
return null;
});
Expand Down Expand Up @@ -258,6 +264,7 @@ private static void handleGetSchemaResponse(AsyncResponse response, SchemaAndMet
.entity(convertSchemaAndMetadataToGetSchemaResponse(schema)).build());
}
} else {
log.error("Failed to get schema", error);
response.resume(error);
}

Expand All @@ -278,6 +285,7 @@ private static void handleGetAllSchemasResponse(AsyncResponse response, List<Sch
.build());
}
} else {
log.error("Failed to get all schemas", error);
response.resume(error);
}
}
Expand All @@ -294,4 +302,6 @@ private void validateDestinationAndAdminOperation(boolean authoritative) {
}
}
}

private static final Logger log = LoggerFactory.getLogger(SchemasResourceBase.class);
}

0 comments on commit 216623d

Please sign in to comment.