Remove test app context #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rsyring
commented
Oct 23, 2017
rsyring
commented
- Remove "fix" for flask-wtf "bug" fixes Remove "fix" for flask-wtf "bug" #91
- Correct usage of Flask's app context during testing - fix Incorrect usage of Flask's app context during testing #90
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
==========================================
- Coverage 89.37% 89.28% -0.09%
==========================================
Files 30 29 -1
Lines 2399 2379 -20
Branches 224 219 -5
==========================================
- Hits 2144 2124 -20
Misses 185 185
Partials 70 70 |
nZac
force-pushed
the
remove-test-app-context
branch
from
bc27780
to
d0bb272
Compare
guruofgentoo
force-pushed
the
remove-test-app-context
branch
from
d0bb272
to
d50d288
Compare
Don't create an application context during testing. See #90 for more info on the reason why this was problematic. Adjust test fixtures to compensate. BREAKING CHANGE --------------- No longer initializing an app context means that flask.current_app as well as keg.db.db operations may fail where they did not previously. You will need to adjust your test fixtures to either get the app instance directly or create the app context as needed. The changes to our tests in this commit will provide good examples of different kinds of fixture usage that can be used to work around this change.
guruofgentoo
force-pushed
the
remove-test-app-context
branch
from
66acefb
to
f9e8ad3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.