Upgrade GRPC to v1.53.0 #6734
Merged
Upgrade GRPC to v1.53.0 #6734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added to the balancer.SubConn interface by grpc v1.51.0
This is based on the upstream breaking-change in v1.53 grpc/grpc-go#5852
beautifulentropy
previously approved these changes
Mar 13, 2023
jsha
previously approved these changes
Mar 13, 2023
mcpherrinm
requested review from
jsha and
beautifulentropy
and removed request for
jsha and
beautifulentropy
|
merge conflict resolved. |
mcpherrinm
requested review from
jsha and
beautifulentropy
and removed request for
jsha and
beautifulentropy
|
Sorry for the flapping review requests; I was mildly confused by the Github UI and a bit of lag. |
jsha
approved these changes
Mar 15, 2023
aarongable
approved these changes
Mar 15, 2023
| @@ -34,7 +34,7 @@ require ( | |||
| golang.org/x/sync v0.1.0 | |||
| golang.org/x/term v0.5.0 | |||
| golang.org/x/text v0.8.0 | |||
| google.golang.org/grpc v1.49.0 | |||
| google.golang.org/grpc v1.53.0 | |||
There was a problem hiding this comment.
Note to self: we should follow this change up with a similar update to the protoc and gRPC versions baked into our docker environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade grpc to v1.53.0, as preparation for introducing OpenTelemetry, which depends on that grpc version.
Two changes to our own code were necessitated by upstream changes:
Add a stub implementation of GetOrBuildProducer: this was added to the balancer.SubConn interface by grpc v1.51.0
Change use of Endpoint field to Endpoint() method: the field was removed and replaced by a method in resolver: replace resolver.Target.Endpoint field with Endpoint() method grpc/grpc-go#5852. This also means that our tests can't set the .Endpoint field, so the tests are updated to use the .URL field instead, and a helper has been added to make that easy.
Part of #6361