Add GitHub Action for golangci-lint #5973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongable
previously approved these changes
Feb 28, 2022
.github/workflows/golangci-lint.yml
Outdated
Comment on lines
2
to
9
| on: | ||
| push: | ||
| tags: | ||
| - v* | ||
| branches: | ||
| - master | ||
| - main | ||
| pull_request: |
There was a problem hiding this comment.
Our other CI workflow triggers on:
on:
# Triggers the workflow on push or pull request events but only for the main branch
push:
branches:
- main
- release-branch-*
pull_request:
branches:
- '**'
These are nearly the same, but I think consistency would be better.
aarongable
approved these changes
Feb 28, 2022
jsha
added a commit
to jsha/boulder
that referenced
this pull request
May 24, 2022
This reverts commit 5fe5859.
jsha
added a commit
that referenced
this pull request
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapted from https://github.com/golangci/golangci-lint-action#how-to-use. Uses the same version we've been using in boulder-tools.
Part of #5946
Note: we will eventually want to go back to doing this in boulder-tools, so it's easy to run the lints locally. But this is useful so we can unblock testing on go 1.18beta2.