Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance regression when upgrading go-sql-driver/mysql to v1.6.0 #5437

Closed
jsha opened this issue May 25, 2021 · 3 comments
Closed

Performance regression when upgrading go-sql-driver/mysql to v1.6.0 #5437

jsha opened this issue May 25, 2021 · 3 comments
Milestone
Sprint 2021-06-08

Comments

@jsha
Copy link
Contributor

jsha commented May 25, 2021

We see:

  • Higher CPU usage on our database
  • Higher latency for certain SA RPCs, particularly for those that make multiple DB queries.
@jsha jsha added this to the Sprint 2021-05-25 milestone May 25, 2021
@jsha jsha self-assigned this May 25, 2021
@aarongable
Copy link
Contributor

We suspect this commit in go-sql-driver/mysql v1.6.0 as the "root" cause: go-sql-driver/mysql#1095

@jsha
Copy link
Contributor Author

jsha commented May 26, 2021

Or possibly this one: go-sql-driver/mysql#1174

@pgporada pgporada mentioned this issue Feb 2, 2023
Merged
@aarongable
Copy link
Contributor

We have now upgraded to go-sql-driver/mysql v1.7.0 and have not observed a similar performance regression. We are not sure whether this is due to changes in v1.7.0 or due to our introduction of proxysql since the last time this upgrade was attempted. Regardless, this bug can be closed.

@aarongable aarongable mentioned this issue Sep 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Sprint 2021-06-08
Development

No branches or pull requests
2 participants
@jsha @aarongable