New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Master container style fix for 4235 #4237
Conversation
parse the correct entities for a comma separated list so that all URLs are rewritten correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style
is much too specific. More function-like constructs are being added and more may follow. Please make parsing more generic and look at function parsing to correctly capture parsing here.
fixes issue less#4235 where container query style would have invalid space after keyword
90379d6
to
aa60398
Compare
Rewrote solution to use function parsing to be more flexible for future functions in declarations of at-rules. Updated container at-rule tests. Tests pass locally. @matthew-dean |
@puckowski Thanks! |
@iChenLei Do you believe we can merge this pull request? |
@matthew-dean Do you believe we can merge this pull request? I'd like to update some dependent projects to add support for |
@puckowski Oh yup, let's do it. Holidays + covid made me miss this. |
What:
Fixes issue #4235
style
keyword would have invalid space after keyword in container queries.Why:
With the invalid space, the CSS is not parsed correctly by browsers.
Checklist:
Tests passing locally. Updated one test case for container queries.