New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: windows #4213

Merged

iChenLei merged 24 commits into less:master from iChenLei:windows-ci

Sep 14, 2023

Member

iChenLei commented Aug 20, 2023 •

edited

What:

Try to recover windows ci

Why:

#3814 (comment)

Checklist:

Documentation
Added/updated unit tests
Code complete

iChenLei added 3 commits

August 20, 2023 10:27


          chore: try run scripts directly


          chore: only trigger windows ci

e021449


          chore: remove resolve-bin

c2afcac

iChenLei changed the title ~~chore: try run scripts directly~~ ci: windows ci

iChenLei added 16 commits

August 20, 2023 11:32


          fix: windows ci

7929ba5


          fix: windows path

0ae9cc4


          chore: try path

a561dc7


          chore: print gen

83d1d93


          chore: remove linux test

4c6129f


          chore: debug windows path

4b164ae


          chore: compare unix system


          chore: try change path

5915d5f


          chore: noramlize path

bed9b93


          chore: switch windows

ea3229b


          fix: bug

e3f9a5e


          chore: windows ci


          chore: up timeout

1c566a7


          chore: up timeout

dfe5247


          chore: match more tests

c0a4d59


          chore: clean code

985782d

iChenLei requested a review from matthew-dean

August 20, 2023 07:24

iChenLei commented

View reviewed changes

.github/workflows/ci.yml Show resolved Hide resolved

iChenLei commented

View reviewed changes

packages/less/Gruntfile.js Show resolved Hide resolved

iChenLei commented

View reviewed changes

packages/less/test/browser/generator/runner.config.js Show resolved Hide resolved

iChenLei commented

View reviewed changes

packages/less/test/browser/generator/template.js Outdated Show resolved Hide resolved

iChenLei commented

View reviewed changes

packages/less/test/browser/generator/runner.config.js Outdated Show resolved Hide resolved

Member Author

iChenLei commented Aug 20, 2023 •

edited

@iChenLei **** Otherwise I've fixed the other tests. Also would you be able to update the change log? #3814 (comment)

I will open a separate PR for CHANGELOG. -> #4215

lubber-de mentioned this pull request

build(deps): bump less from 4.1.3 to 4.2.0 fomantic/Fomantic-UI#2873

Merged

iChenLei and others added 2 commits

September 7, 2023 10:29


          use path.posix.normalize

fa9b41f


          ci: debug path

67a99ad

iChenLei commented

View reviewed changes

packages/less/test/browser/generator/runner.config.js Outdated Show resolved Hide resolved

iChenLei added 3 commits

September 8, 2023 09:13


          chore: test utils

7315d5e


          chore: update logic

fdafcde


          chore: reduce diff content

2b2713f

iChenLei changed the title ~~ci: windows ci~~ ci: windows

Member Author

iChenLei commented Sep 14, 2023

@matthew-dean Apply your suggestion, please review.

matthew-dean approved these changes

View reviewed changes

Member

matthew-dean left a comment

Looks great, thanks!

iChenLei merged commit 13864a6 into less:master

8 checks passed

iChenLei deleted the windows-ci branch

September 15, 2023 00:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment