Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the lack of the optional dependencies #3791

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 14 additions & 3 deletions packages/less/src/less-node/environment.js
@@ -1,16 +1,27 @@
class SourceMapGeneratorFallback {
addMapping(){}
setSourceContent(){}
toJSON(){
return null;
}
};

export default {
encodeBase64: function encodeBase64(str) {
// Avoid Buffer constructor on newer versions of Node.js.
const buffer = (Buffer.from ? Buffer.from(str) : (new Buffer(str)));
return buffer.toString('base64');
},
mimeLookup: function (filename) {
return require('mime').lookup(filename);
const mimeModule = require('mime');
return mimeModule ? mimeModule.lookup(filename) : "application/octet-stream";
},
charsetLookup: function (mime) {
return require('mime').charsets.lookup(mime);
const mimeModule = require('mime');
return mimeModule ? mimeModule.charsets.lookup(mime) : undefined;
},
getSourceMapGenerator: function getSourceMapGenerator() {
return require('source-map').SourceMapGenerator;
const sourceMapModule = require('source-map');
return sourceMapModule ? sourceMapModule.SourceMapGenerator : SourceMapGeneratorFallback;
}
};
2 changes: 1 addition & 1 deletion packages/less/src/less-node/image-size.js
Expand Up @@ -31,7 +31,7 @@ export default environment => {
}

const sizeOf = require('image-size');
return sizeOf(fileSync.filename);
return sizeOf ? sizeOf(fileSync.filename) : {width: 0, height: 0};
}

const imageFunctions = {
Expand Down