Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: '..' shouldn't be ignored if directories is empty #3738

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ArrayZoneYour
Copy link

@ArrayZoneYour ArrayZoneYour commented Jul 10, 2022

What:

append .. to directories if directories is empty

Why:

pathDiff will broken if url startsWith ..

AbstractFileManager.prototype.pathDiff('../assets/', '') returns assets/ now

How:

pop directories only if it is not empty

Checklist:

  • Documentation
  • Added/updated unit tests
  • Code complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant