Resolve #3398 Add flag to disable sourcemap url annotation #3517
+55
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hirosato
changed the title
hirosato
force-pushed
the
add-flag-to-disable-sourcemap-url-annotation
branch
from
458d2d3
to
1c4c51a
Compare
|
"Disable" seems ok since having the annotation present by default is the intuited (default) behavior. |
I get it. thank you for review and comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small doubts
Shall I use positive form for the property? I mean using
appendSourcemapUrlAnnotation, for example, instead ofdisableSourcemapAnnotationsounds more straightforward for me. In other words,disableSourcemapAnnotation: false/truelooks a little bit confusing.--source-map-no-annotation, on the other hand, looks ok for me since it does not have true/false value with it.