Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(recondition): replace dependency request with native-request #3501

Closed
wants to merge 1 commit into from
Closed

chore(recondition): replace dependency request with native-request #3501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions bin/lessc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,7 @@ var UrlFileManager = /** @class */ (function (_super) {
return new Promise(function (fulfill, reject) {
if (request === undefined) {
try {
request = require('request');
request = require('native-request');
}
catch (e) {
request = null;
Expand Down Expand Up @@ -7006,7 +7006,7 @@ var Parser = function Parser(context, imports, fileInfo) {
function f(parse, stop) {
return {
parse: parse,
stop: stop // when true - stop after parse() and return its result,
stop: stop // when true - stop after parse() and return its result,
// otherwise continue for plain args
};
}
Expand Down
4 changes: 2 additions & 2 deletions lib/less-node/url-file-manager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@ class UrlFileManager extends AbstractFileManager {
loadFile(filename, currentDirectory, options, environment) {
return new Promise((fulfill, reject) => {
if (request === undefined) {
try { request = require('request'); }
try { request = require('native-request'); }
catch (e) { request = null; }
}
if (!request) {
reject({ type: 'File', message: 'optional dependency \'request\' required to import over http(s)\n' });
reject({ type: 'File', message: 'optional dependency \'native-request\' required to import over http(s)\n' });
return;
}

Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@
"errno": "^0.1.1",
"graceful-fs": "^4.1.2",
"image-size": "~0.5.0",
"make-dir":"^2.1.0",
"make-dir": "^2.1.0",
"mime": "^1.4.1",
"native-request": "^1.0.5",
"promise": "^7.1.1",
"request": "^2.83.0",
"source-map": "~0.6.0"
},
"devDependencies": {
Expand Down