Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(run): inherit stdio for running npm scripts #3881

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

amorscher
Copy link
Contributor

  • supports handling of user prompts in npm scripts

Description

Fixes #3835 when not using nx as the task runner

Motivation and Context

#3835

How Has This Been Tested?

Adapted unit test.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

 - supports handling of user prompts in npm scripts
@amorscher amorscher marked this pull request as draft October 27, 2023 23:10
@amorscher amorscher force-pushed the fix-inquirer-prompt branch 3 times, most recently from dfff223 to 40ddb8f Compare November 24, 2023 00:08
@JamesHenry
Copy link
Member

@amorscher what's the status of this one please?

@amorscher
Copy link
Contributor Author

@JamesHenry i will have a look at the issue this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lerna is not redering inquirer prompt properly
3 participants