Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(version): pass npmClientArgs to npm install cmd #3427

Closed
wants to merge 1 commit into from

Conversation

amorscher
Copy link
Contributor

  • support -- args assign as well

Passes provided npmClient args to used npm install when executing lerna version -- --legacy-peer-deps

Description

Motivation and Context

Problems raised in #3386 and #3418

How Has This Been Tested?

Added unit test.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

 - support -- args passign as well
@amorscher
Copy link
Contributor Author

@JamesHenry any chance that the fix will make it to main?
Thx for having a look.

@jeeten-parmar
Copy link

@JamesHenry Can you please do the needful? It has blocked our some work so we are also waiting for this change.

@fahslaj
Copy link
Contributor

fahslaj commented Dec 21, 2022

@amorscher Thank you very much for your work on this PR! As mentioned in a different comment, I do not think it is appropriate to add -- args forwarding back to the lerna version command. Since A different PR has been merged that adds support for --npmClientArgs on lerna version, I do not believe that this PR is necessary anymore. Please feel free to reach out if you disagree or have any other questions or concerns.

@fahslaj fahslaj closed this Dec 21, 2022
@amorscher amorscher deleted the use-npm-client-args branch March 29, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants