Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(run): only defer to Nx when targetDefaults are defined in nx.json #3349

Merged
merged 3 commits into from Sep 29, 2022
Merged

fix(run): only defer to Nx when targetDefaults are defined in nx.json #3349

merged 3 commits into from Sep 29, 2022

Conversation

fahslaj
Copy link
Contributor

@fahslaj fahslaj commented Sep 29, 2022 •
edited

Change lerna run to only pass target dependencies to Nx when there are not target defaults already defined in nx.json

Description

Motivation and Context

Follow up / partial reversion of:
#3345

How Has This Been Tested?

This has been covered by e2e tests for the run command.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@JamesHenry JamesHenry mentioned this pull request Sep 29, 2022
Merged
10 tasks
@fahslaj fahslaj marked this pull request as ready for review September 29, 2022 20:01
@vsavkin vsavkin merged commit 51f80d9 into lerna:main Sep 29, 2022
@fahslaj fahslaj deleted the check-nxjson-contents branch September 29, 2022 20:38
@ghiscoding ghiscoding mentioned this pull request Oct 2, 2022
Merged
9 tasks
rrhodes pushed a commit to rrhodes/lerna that referenced this pull request Jan 3, 2023
@fahslaj
fix(run): only defer to Nx when targetDefaults are defined in nx.json (…
114f6a3 
…lerna#3349)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fahslaj @vsavkin