Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(conventional-commits): remove pinned lodash.template #3172

Merged
merged 1 commit into from Jun 13, 2022
Merged

fix(conventional-commits): remove pinned lodash.template #3172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Expand Up @@ -103,12 +103,12 @@ If you want to test out Lerna on local repos, you can leverage verdaccio as a lo
Open a new terminal window and run the following from the root of the workspace:

```sh
$ npx lerna run --scope @lerna/e2e start-verdaccio
npx lerna run --scope @lerna/e2e start-verdaccio
```

This will run verdaccio on http://localhost:4872

In another terminal window you can now publish any new version (in this example `999.9.9`) to that local registry:
In another terminal window you can now build and publish any new version (in this example `999.9.9`) to that local registry:

```sh
npm run e2e:local-publish -- 999.9.9
Expand Down
1 change: 0 additions & 1 deletion core/conventional-commits/package.json
View file
Open in desktop
Expand Up @@ -38,7 +38,6 @@
"conventional-recommended-bump": "^6.1.0",
"fs-extra": "^9.1.0",
"get-stream": "^6.0.0",
"lodash.template": "^4.5.0",
"npm-package-arg": "^8.1.0",
"npmlog": "^6.0.2",
"pify": "^5.0.0",
Expand Down
2 changes: 1 addition & 1 deletion e2e/publish-to-verdaccio.sh
View file
Open in desktop
Expand Up @@ -24,7 +24,7 @@ fi
# Change to the prepared dist directory
cd ../dist

echo "Updating the package versions in $(pwd)/dist to use $VERSION"
echo "Updating the package versions in $(pwd) to use $VERSION"

echo ""

Expand Down
47 changes: 0 additions & 47 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions package.json
View file
Open in desktop
Expand Up @@ -24,7 +24,7 @@
"ci:windows": "jest --ci --maxWorkers=2 && npm run integration -- --ci",
"build": "scripts/build.sh",
"e2e": "npm run build && npx lerna run --scope @lerna/e2e e2e",
"e2e:local-publish": "npm run --workspace e2e publish-to-verdaccio",
"e2e:local-publish": "npm run build && npm run --workspace e2e prepare-local-publish && npm run --workspace e2e publish-to-verdaccio",
"fix": "npm run lint -- --fix",
"integration": "jest --config jest.integration.js --maxWorkers=2",
"ci:lint": "eslint . -c .eslintrc.yaml --no-eslintrc --ignore-path .gitignore",
Expand Down Expand Up @@ -71,7 +71,6 @@
"libnpmaccess": "^4.0.1",
"libnpmpublish": "^4.0.0",
"load-json-file": "^6.2.0",
"lodash.template": "^4.5.0",
"minimatch": "^3.0.4",
"multimatch": "^5.0.0",
"node-fetch": "^2.6.1",
Expand Down