Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2943: removes lodash.template dependency #3078

Closed

Conversation

slawiko
Copy link

@slawiko slawiko commented Feb 12, 2022

Removes vulnerable unused package (CVE-2021-23337)

Description

#2943

Motivation and Context

I wanted to replace lodash.template@4.5.0 with lodash@4.17.21 in the first place. But then I noticed that there is no lodash imports across the project, so I decided to remove this dependency at all.

Important make sure it is really unused dependency. If it is not, I'll update the PR.

How Has This Been Tested?

I ran npm test and npm run lint in the root of monorepo

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@slawiko
Copy link
Author

slawiko commented Mar 4, 2022

@evocateur ping, could you please approve me as a first-time contributor?

@JamesHenry
Copy link
Member

Hi @slawiko 👋

You may or may not know that lerna is now under the stewardship of Nrwl (announcement here #3121), a company with a long history of not just producing valuable open-source software (OSS), but also backing others (at the time of writing, Nrwl has donated over $50,000 to OSS it hasn't created, see https://opencollective.com/nx for full details).

Quite simply, Nrwl ❤️ OSS, and is committed to making lerna the best it can be. We use it ourselves.

We hope you will continue to be a part of this community as we look to take things forward from here!

Please see #3140 for more details on our plans for 2022.

In the case of this specific PR, because of its age and the conflicts which would have to be resolved locally, I went ahead and pushed this change in a fresh PR #3172 so that I can cut a patch of lerna with it included.

Many thanks again for your contribution 🙏

@JamesHenry JamesHenry closed this Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants