Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(utils): check validity of bundledDependencies before iteration #2960

Merged
merged 2 commits into from Dec 13, 2022
Merged

fix(utils): check validity of bundledDependencies before iteration #2960

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
084d857
check validity of bundledDependencies before iteration
davidmeirlevy Aug 3, 2021
2396bb6
fix: update utils/npm-install/npm-install.js
JamesHenry Dec 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion utils/npm-install/npm-install.js
View file
Open in desktop
Expand Up @@ -132,7 +132,7 @@ function transformManifest(pkg, dependencies) {

["bundledDependencies", "bundleDependencies"].forEach((depType) => {
const collection = json[depType];
if (collection) {
if (collection instanceof Array) {
JamesHenry marked this conversation as resolved.
Show resolved Hide resolved
const newCollection = [];
for (const depName of collection) {
if (depMap.has(depName)) {
Expand Down