feat(version): add --signoff git flag #2897
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com
Description
Provide a CLI flag to enable signing off on the git commits made by
lerna version
.Currently this is not supported, only gpg signatures are, which is a different thing entirely despite the very similar sounding name.
https://stackoverflow.com/a/64840893/698470
Motivation and Context
When issuing releases on a project I help maintain, there's a check for DCO and this currently cannot be satisfied unless you manually jerry rig the commit after the fact, but this then leads to your npm packages being published with a revision of the code that you disappear right after with a force push while cleaning up.
How Has This Been Tested?
I didn't, the linter has 500+ errors so I couldn't run the tests locally. I was hoping the CI here would be set up to run the automated tests (which I did add so there is test coverage I just never ran it locally)
Types of changes
Checklist: