Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: drastically reduce time taken to check for cycles #2874

Merged
merged 1 commit into from Jun 14, 2022
Merged

fix: drastically reduce time taken to check for cycles #2874

merged 1 commit into from Jun 14, 2022

Commits on Jun 14, 2022

  1. fix: drastically reduce time taken to check for cycles 

    In our monorepo with 219 packages, `lerna exec` takes 5 minutes
to check for cycles in our package graph.

Most of time is spent checking and re-checking the same nodes over
and over again.

Add a double-work breaker (a `Set` of already-visited nodes) to only
visit every package once.

Brings the time taken down to virtually nothing.
    @rix0rrr @JamesHenry
    rix0rrr authored and JamesHenry committed Jun 14, 2022
    Copy the full SHA
    11416bb View commit details
    Browse the repository at this point in the history