New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(publish): add --summary-file option #2653
feat(publish): add --summary-file option #2653
Conversation
This would be really useful in CI where it could be used for checking what will happen when a pull-request is merged |
7d7b638
to
f0cc5ac
Compare
Hey @evocateur, Is there anything else that needs to be done here? 😄 |
@HamishBuckmaster there are tests failing, see travis-ci |
9d6e277
to
4a3fc81
Compare
It's passing now, @g5bot. 😋 |
Eager for this feature, any plans on merging? |
Merge it please |
7c623fd
to
43f8ff4
Compare
Outputs the packages and versions from publishing to a JSON file.
43f8ff4
to
fde364e
Compare
Hi @evocateur / @gigabo, All these tests are passing on local, can you provide any advice as to why they are failing? |
When will this feature be supported ? |
I would also have good use for this functionality! |
I also have good use for this! |
I'd love to see this merged. My use case is that I'd like my CI pipeline to add a comment to the originating pull request with the relevant versions / yarn add commands, so that we can grab them from github rather than digging into the CI logs. It's a minor inconvenience to have to drop into the CI logs, but still inconvenient. I could probably capture the existing raw output and parse/dump that onto a comment, but a JSON file would be a lot cleaner to process. |
I'd be happy to have this feature as well! 🙂 |
@JamesHenry / @vsavkin are you happy with the above approach, would like to get this merged once and for all 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @HamishBuckmaster I can see that this would be a useful feature!
Please kindly check out the comments I left inline, and also please update the lerna-schema.json
to include this new option
Co-authored-by: James Henry <james@henry.sc>
4a088e1
to
6b208e7
Compare
Hi @HamishBuckmaster do you have time to continue working on this? |
Yes! @JamesHenry, will have a look when I get a chance |
@HamishBuckmaster I think we are just down to a formatting issue now |
Thanks so much again for your patience and work on this @HamishBuckmaster! |
Thanks for your patience @JamesHenry |
Outputs the packages and versions from publishing to a JSON file.
Description
When
lerna publish --summary-file <path-to-file>
It'll create a file to easily see what's been published and what version has been.Happy to rename --summary-file to something more meaningful
Motivation and Context
When creating a release you don't get a definitive and easy way to see whats changed in a nice output especially if its a pre-release(canary), So added the ability to output a JSON object to a file which would look something like this.
#2053
How Has This Been Tested?
Types of changes
Checklist: