fix(list): force-local option for list command #2634
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm having troubles trying to run my
lerna exec built
script because the dependency-graph is not correctly built.I've found this issue in a development branch, while publishing some beta releases of my packages.
I've tracked down the issue to
PackageGraphNode.satisfies
because
semver('14.0.0-beta.0', '*')
is returning false, and that puts my beta packages asexternalDependencies
insteadlocalDependencies
while initializing thePackageGraph
.So looking at the options, I saw the
forceLocal
parameter that seems supported by bootstrap only, and I added it to thelistable.options
too so we can workaround this bug withsemver
while they have a fix.Motivation and Context
The bug was reported 11 days ago without feedback ATM:
npm/node-semver#331
and 26 days ago the first question was posted:
npm/node-semver#329
How Has This Been Tested?
I've used this patch locally in the node_modules of my beta-branch
and it works as expected :)
Types of changes
Checklist: