Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(version): use npmClientArgs in npm install after lerna version #3434

Merged
merged 6 commits into from Dec 21, 2022
Merged

feat(version): use npmClientArgs in npm install after lerna version #3434

merged 6 commits into from Dec 21, 2022

Conversation

fahslaj
Copy link
Contributor

@fahslaj fahslaj commented Nov 18, 2022 •
edited

Adds configured npmClientArgs to the npm install command that happens at the end of lerna version.

Motivation and Context

#3386

How Has This Been Tested?

Tested manually and covered by e2e tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@fahslaj fahslaj changed the title fix(version): use npmClientArgs in npm install after lerna version feat(version): use npmClientArgs in npm install after lerna version Nov 18, 2022
@amorscher
Copy link
Contributor

amorscher commented Nov 19, 2022 •
edited

Similar to #3427. I think we can align changes and skip one of them.

@ghiscoding ghiscoding mentioned this pull request Dec 5, 2022
Open
@ghiscoding ghiscoding mentioned this pull request Dec 13, 2022
Merged
9 tasks
@fahslaj fahslaj force-pushed the 3386-use-npm-client-args-in-version branch from 95dc451 to e682ad0 Compare December 16, 2022 19:43
@fahslaj fahslaj marked this pull request as ready for review December 16, 2022 20:28
@fahslaj fahslaj marked this pull request as draft December 16, 2022 20:34
@fahslaj fahslaj marked this pull request as ready for review December 16, 2022 20:53
@fahslaj fahslaj merged commit e019e3f into lerna:main Dec 21, 2022
@fahslaj fahslaj deleted the 3386-use-npm-client-args-in-version branch December 21, 2022 17:32
@ghiscoding ghiscoding mentioned this pull request Dec 22, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesHenry JamesHenry JamesHenry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fahslaj @amorscher @JamesHenry